[SPARK-52218][SQL] Make current datetime functions evaluable again #50936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
reviewed
May 19, 2025
cloud-fan
commented
May 27, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala
Show resolved
Hide resolved
…essions/timeExpressions.scala
cloud-fan
commented
May 27, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala
Outdated
Show resolved
Hide resolved
MaxGekk
approved these changes
May 30, 2025
|
I think the tes failure is not related to the changes: |
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Current date-time functions should only be evaluated all together in the rule
FinishAnalysis, so that they have the same consistent value across the entire query plan. To do that we mark current date-time functions asUnevaluablea while ago. Unfortunately, there are still some places that have to evaluate expressions earlier, and the expression may contain current date-time functions. #50800 is one such example.I think the move to mark these functions as
Unevaluableis too aggressive. This PR proposes to revert this restriction to avoid potential regressions. I think the better way forward is to introduce query context to pre-evaluate these current datetime values, and the expressions just get values from the query context and makes sure it produces consistent values during the query life cycle.Why are the changes needed?
to avoid potential regressions.
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
no